Add Pool connection retry delay for failed useTube command #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 98.66% 98.66%
Complexity 362 362
=========================================
Files 41 41
Lines 1124 1125 +1
=========================================
+ Hits 1109 1110 +1
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #38 . Full solution will be #37 .
As the server wasn't being delayed for a retry, the scenario in #38 of calling
useTube()immediately followed byput()allowed the job to be put to a server that should have been marked as failed.Using
tryCommandwill mark the server as failed, and the subsequentput()will not choose the server which did not accept theuseTubecommand.